search

vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

Linting errors and warnings #387

Open anthonyronda opened 1 year ago

anthonyronda commented 1 year ago

What happened?

  1. run npm run build with or without watch flag
  2. Lots of errors and warnings appear
  3. The build script still emits a working(?) dist/ folder

What is the expected behaviour?

Linting errors do not represent build failures but they look like build failures to our new contributors. Even still, we expect for these warnings to be helpful to those contributors so we can encourage them to adhere to a higher code quality standard. Therefore, we should eliminate all linting errors, and most if not all warnings.

Relevant Errors and Warnings

No response

Additional Support Details

No response

Foundry VTT Core Version

None

Old-School Essentials Core Version

1.7.7

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

anthonyronda commented 1 year ago

Grah forgot to link #266

This comes to us after completing #266