vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

fix: individual init reroll each round now works #397

Closed anthonyronda closed 1 year ago

anthonyronda commented 1 year ago

Please read #200.

I unfortunately don't remember how I arrived at the fix in #280 that resulted in bug #338. I think it was quite difficult to find somewhere else to interrupt the unwanted behavior.

The fix here is once again crude, but it's tough because "Start Combat" and "Next Round" are semantically different operations, and we're kind of cornered into using the same initiative function for each.

I think it's worth considering a future refactor such that changes to one combat roll option no longer impact the other two combat round roll options.