vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

Dragging new Character Sheets does not Link Token to Sheet #425

Open seansps opened 1 year ago

seansps commented 1 year ago

What happened?

  1. Create a new character sheet
  2. Drag the character to the active scene
  3. Notice the token is dropped
  4. Close the sheet
  5. Double click on the token, make a change, close the sheet
  6. Open the original sheet, notice that the change was only applied to the token dropped

What is the expected behaviour?

By default, I'd expect that Character Sheets are always linked back to their Actors. This also makes it so that PCs editing their sheets or setting tokens get updated on the master record.

Relevant Errors and Warnings

No response

Additional Support Details

No response

Foundry VTT Core Version

V10

Old-School Essentials Core Version

Latest

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

justinthejaguar commented 1 year ago

This seems like a core thing where you are missing a step. Only because you did not mention it, are you linking the data on the actor? Screenshot 2023-05-10 at 8 58 34 AM

seansps commented 1 year ago

That could be the case, I don't think I ever clicked that. I am coming from the PF2E system in Foundry, where that is done automatically for users. So, this is probably more of a suggestion than a bug in this case -- but I think perhaps it should be done automatically for Character Sheets as I never see a case where they'd want it to not behave that way. (Less clicking for setting up new characters too, which have a much shorter life span in OSE!)

justinthejaguar commented 1 year ago

That makes sense, though there are times when encountering other adventuring parties where one might not want to link actors. https://oldschoolessentials.necroticgnome.com/srd/index.php/Adventuring_Parties#Expert_Adventurers.

anthonyronda commented 1 year ago

Good suggestion (for the default case), I'll happily convert this to an enhancement issue