feat: Issue #425 - Add default "Link Actor Data" for Characters

[Stew-rt]

Add default "Link Actor Data" to new Actor's prototypeToken if it's type is character and is not from a Compendium. Also provided two extra options which would be sane but do not cover the Issue, so commented out.

[wyrmisis]

Any chance you could add some testing for this?

[Stew-rt]

Sure. Just working on #424 at the mo.. so might be a little bit.

[Stew-rt]

I've added tests.. but i'm not sure how this project runs them, sorry if i'm being dumb.

[wyrmisis]

Not a problem! The Foundry ecosystem is just weird :)

You'll want to pick up the Quench module. That'll run tests for you.

[Stew-rt]

Finally got tests for the 3 features working. Now I know to not trust my IDE's linter at all for Foundry stuff.

Also, I had to have my test clean some stuff up after, as Quench doesn't seem to remove Compendiums created during a test routine.

[Stew-rt]

Ironically, this implementation is robbed almost verbatim from the official DnD5 system, as my familiarity with the foundry base is limited.

But fair do's, I'll take another look around and try again. 🙂

[anthonyronda]

5e? Who plays that? 😆

Great, thanks, no rush obviously!

[anthonyronda]

Just leaving this here for us to monitor https://github.com/foundryvtt/foundryvtt/issues/9567

[anthonyronda]

Noting that the bugged behavior blocking this issue is still awaiting V12 (unless someone finds a better solution, but likely the linked issue above will lead to the best way of solving it)

[anthonyronda]

Noting that the bugged behavior blocking this issue is still awaiting V12 (it has been pushed several times now)