fix(OseCharacterCreator): #424 - don't print on close, don't print Failure() on rolls

[Stew-rt]

fix for issue #424

• sets FormApplication option, submitOnClose to false.
• migrated Gather scores to _onSubmit override
• Added default to data.roll.type check in helpers-dice.js, setting isSuccess AND isFailure to false.
• set data object in call to OseDice.Roll to not provide type Object.

I'd quite like to re-work some of this more. But this resolves the reported issue.

Would like to tidy a bit and add two features: 1) Count re-rolls for manually rolled stats (and present totals in final form) 2) Provide a system option for different rolling standards, such as point buy and roll 4d6, deduct the lowest.

[anthonyronda]

Thanks for your patience, I'll be beginning your review now

As for the point buy and drop lowest, once we have more modularity to support that in UFT, that will be the place to do it. Feel free to ask in the discord server what our plans are with that.

[anthonyronda]

@all-contributors please add @Stew-rt for code 🎉

[allcontributors[bot]]

@anthonyronda

I've put up a pull request to add @Stew-rt! :tada:

[anthonyronda]

@Stew-rt please look at #59 and provide your preferred attribution details!