vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 52 forks source link

fix(macros): #355 Accept RollTable drops onto Macro hotbar #449

Closed Stew-rt closed 1 year ago

Stew-rt commented 1 year ago

Attempts to address, #355 Allows dropping RollTables onto Hotbar, resulting in Macro creation to Roll on them.

If this implementation is acceptable (hi-jacking existing if statement, heavily oriented around Items) - i'll go ahead and modify/write tests.

If this wants re-writing, to be more generic, let me know and i'll do that first.

Stew-rt commented 1 year ago

Reverted to Type based detection and improved rollTableMacro so it works on Objects in RollTables AND Compendiums by uuid (opposed to existing implementation using Name, which i didn't feel would be very reliable)

anthonyronda commented 1 year ago

Great! I figure at some point all of them need to be by uuid 😁 Reviewing now

anthonyronda commented 1 year ago

re: your explanation for keeping this a draft, your approach here is perfect for us, so feel free to un-draft it when you make these changes 😄