vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 52 forks source link

Default Tokens from Adv. Fantasy Monster Compendium does not use Foundry Token Defaults. #454

Open lonpalmer opened 1 year ago

lonpalmer commented 1 year ago

What happened?

When Foundry VTT Token Defaults are set, the Monster records do not seem to use those defaults when the tokens are placed, nor when the token prototypes are edited.

Note, it doesn't matter if the Monsters are imported or taken straight from the compendium.

image

What is the expected behaviour?

The foundry defaults should be used for monster records in Adv. Fantasy.

Relevant Errors and Warnings

No response

Additional Support Details

Foundry Virtual Tabletop: Version 11 Stable, 11.299 Game System: ose, 1.9.1 Active Modules: 30 Performance Mode: 1

OS: Unknown Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36 Edg/113.0.1774.57 GPU: ANGLE (NVIDIA, NVIDIA GeForce RTX 3080 Direct3D11 vs_5_0 ps_5_0, D3D11) Max Texture Size: 16384

Scene: 13440 x 9520 | Grid Size: 70 | Padding Percentage: 0.25 Walls: 2072 | Ambient Lights: 358 | Ambient Sounds: 0 | Tiles: 4 | Tokens: 38

Actors: 391 | Items: 723 | Journal Entries: 65 | Rollable Tables: 31 | Playlists: 1 | Compendium Packs: 54 | Chat Messages: 60

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Microsoft Edge

Code of Conduct

anthonyronda commented 1 year ago

Interesting. I bet someone from the Foundry Discord can help me figure out how to restore this. I'll ask around

anthonyronda commented 1 year ago

@lonpalmer I wasn't able to replicate your issue.

I followed these steps:

  1. Drag and drop a monster from the monster compendium directly into a scene. The token's name only shows on hover and there is not a number appended
  2. Change the default token settings to the following: always show token name, enable append number to unlinked token names
  3. Back to the compendium, drag another monster directly into a scene. This token's name always shows, and there's a (1) appended to its name.

Note: the previous token retains its settings. This is the desired behavior.

lonpalmer commented 1 year ago

@anthonyronda

I was looking specifically at "Token Disposition". Note in the screen shot the default Token Disposition is set to "Hostile" but dragging a monster from the compendium sets the disposition on the token to "Friendly".

I just reverified this behavior on a clean install of Foundry + OSE + Advanced.

anthonyronda commented 1 year ago

While I was chatting about this to a Foundry VTT Discord moderator, the belief is that if this is indeed an issue for us to correct, it would be implemented on the ose package and not the ose-advancedfantasytome package. I'm going to move this there because I'm cleaning up my Advanced Fantasy issues ahead of today's release

lonpalmer commented 1 year ago

Just a note, it appears the issue does not affect new actors created directly in OSE. It only seems to affect any actors (monsters) from the compendium.

anthonyronda commented 1 year ago

https://github.com/foundryvtt/foundryvtt/issues/8837 this core FVTT issue might be relevant to what you're seeing