vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

fix: hp/encumbrance attribute bars restored #456

Closed anthonyronda closed 1 year ago

anthonyronda commented 1 year ago

Fixes #453. We've discovered that the wrong Datafield subtype (ObjectField) was being used to define parts of the datamodel (correct subtype: SchemaField). This was apparently not crucial to the overall DataModel definition in terms of how Foundry handled our system's data model until DataModel validation changed in V11. Foundry no longer uses template.json as a general schema for finding the fields being used if there's a datamodel definition, so I believe it could no longer find the fields because we were using ObjectField incorrectly

Anyway here's a screenshot from Foundry while testing this changeset

image
anthonyronda commented 1 year ago

Note: I'm not sure how to test for this

wyrmisis commented 1 year ago

Do we need to make these changes for monsters, too?

anthonyronda commented 1 year ago

Whoops yep