feat: Character Sheet v2

wyrmisis commented 1 year ago

Intent

This changeset implements Phase 1 of the new character sheet, while attempting to maintain the existing character sheet.

Wait, phase one? We never discussed phases!

In the interest of getting this sheet out this year, I'm opting to put it up for review at feature parity (plus a little extra) with the current sheet. In my opinion, adding things like spell sources, ability categories, and so on are too disruptive to the existing character sheet; I'd prefer to hold off on them until we can safely end-of-life the old sheet.

What's missing?

[ ] Combat tab: The character info fields are a little messy, and they're missing Retainer fields.
[ ] Combat tab: The ability to roll HD
[ ] Abilities tab: Use the correct icons for the exploration skills
[ ] Abilities tab: Language picker. I'd like to use Tagify for this.
[ ] Inventory tab: Adding zebra striping to the inventory rows
[ ] Magic tab: dragging a prepared spell to another character's spells will cause the recipient to prepare it, too.
[ ] The ability to add hotbar macros.

Where did I veer "off road"?

I added a dark theme. Sorry @Godforsaken84 :stuck_out_tongue_closed_eyes:
I added a spell slot grid to the top of each spell level on the Magic tab, as well as under the move speed fields on the Combat tab.
Container queries have enabled us to create a flexible UI that adapts to resizing (including on editor fields)
If you drag gear or treasure with a quantity of at least one to another actor, you'll have the option to give that actor a set amount, and optionally deduct that amount from the original owner. We can absolutely remove this if enough modules cover this, though.

Anything else of note?

I'd really appreciate a close look at my drag and drop code. There's just a lot there and I'd like some help simplifying it.
There'll be mentions of FACE, or Form Associated Custom Elements in the code, specifically about how they don't work gracefully in Foundry. for some reason, no matter what, I can't get focus back onto a custom element after editing. Hopefully FACEs work in v12 (because I'm sure the core devs are tired of me asking about it).

Beyond that... This isn't 100% ready to go in, but it can be -- with your help. There's a lot here. I've been staring at it for a long time, and I'm likely missing stuff. Pull the sheet down, and really put it through the ringer.

anthonyronda commented 1 year ago

I'll be taking a few screenshots for folks who want to give feedback without pulling it locally

anthonyronda commented 1 year ago

Weapons in containers appear bugged: can't be clicked on or dragged out of the container. Drag behavior has some issues we'll address in a separate comment