vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
95 stars 51 forks source link

Fix roll formula not being displayed in roll tags #499

Closed apewall closed 4 months ago

apewall commented 6 months ago

This updates the roll tags on abilities and spells so roll formulas can be displayed in the footer cards properly if they include @attributes.

Regarding https://github.com/vttred/ose/issues/488. Duration and Range could likely be calculated similarly but they would probably need to return totals instead and involve adding additional data for turns/rounds/ft etc.

Before when using a 2nd level character: image

After: image

apewall commented 4 months ago

LGTM

I noted that there might be a merge conflict while trying to merge after #497, which I can take care of

Sounds good, these ended up related and I forgot to update the formatting on this. :+1: