vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

Nested Containers Don't Work #502

Open osarusan82 opened 7 months ago

osarusan82 commented 7 months ago

What happened?

When a container is placed in another container, the nested container's contents do not display, and the weight of the nested container no longer calculates the weight of its contents.

What is the expected behaviour?

Expected behavior would be that a nested container would retain the weight of the container and also display the items inside it.

Relevant Errors and Warnings

No errors or warnings appear. Removing the nested container shows that the items are not lost; they reappear after removing the nested container. However they do seem to temporarily "disappear" from the game, as they become invisible and their weight stops being factored.

Additional Support Details

Foundry v. 11.315 OSE 1.10.1

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.10.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox

Code of Conduct

anthonyronda commented 6 months ago

Changed to an enhancement request with design needed. Unfortunately, not showing the items inside is a design constraint.

the weight of the nested container no longer calculates the weight of its contents

This is a slightly poor design. Calculations are still going, but the column that is showing is actually the "quantity of items" column. Only Miscellaneous items have quantities.

If you or someone would like to help us design an elegant way to show what you want to see, we'd welcome giving your design a chance. I also welcome looking at #97 and seeing if you want to contribute your thoughts to that, because currently I don't think that does recursive items either