THAC0 Providing Incorrect Feedback

justinthejaguar commented 4 months ago

What happened?

Reproduction steps - Keep Descending AC/THAC0 settings

Attack without targeting THAC0 19. (no change)
Repeat until you get below a ten
Receive "Hits AC 9" regardless of missing roll.

What is the expected behaviour?

This calculation is incorrect. The AC hit for THAC0 should follow the attack matrix in the books/SRD.

Relevant Errors and Warnings

https://cdn.discordapp.com/attachments/929772978193956935/1213900434847301692/image.png?ex=65f727e0&is=65e4b2e0&hm=f065fe070e40a9e4b15e26bea8d48ad3d3390632152fde02970d435ce9d9df7f&

A character with THAC0 19 needs a 10 to hit AC 9.
A roll of 5 wouldn't hit anything.

Additional Support Details

Electron - MacOS and Node.js on rpi.

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.10.1

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Chrome

Code of Conduct

[X] I agree to follow this project's Code of Conduct

anthonyronda commented 3 months ago

This behavior was purposefully changed in response to #333 and #332, which resulted in the following change

compare with @apewall's change

anthonyronda commented 3 months ago

Switched to design needed, because clearly there's something wrong with the design of the chat card if people keep changing their minds about whether an attack should hit without a target

vttred / ose