search

vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
98 stars 57 forks source link

feat(combat): replace the combat tab with one made for v12 #534

Closed wyrmisis closed 2 months ago

wyrmisis commented 2 months ago

Intent

This changeset completely replaces the existing initiative/combat tracker code with code that uses v12's features for overriding existing pieces of Foundry. It does so by replacing hooks and HTML replacement with new classes for combats, combatants, and the combat tracker sidebar.

It also, if merged, will completely break compatibility with v11; whatever the new release of the system is will need to be for v12+.

Media

Group Initiative, Player View

image

Group Initiative, GM View

image

Individual Initiative, Player View

image

Individual Initiative, GM View

image

Related issues

wyrmisis commented 2 months ago

Fixes the major V12 blocker, will need several UX improvements in separate ticket.

If this thing needs UX improvements, that doesn't sound like it should be approved. Would you mind highlighting the more egregious issues, so we can get them fixed before this goes out?

Rughalt commented 2 months ago

It's more like janky UX, that we can polish later, prioritizing the V12 fixes