search

vtulluru / node-red-contrib-oracledb-mod

MIT License
4 stars 9 forks source link

Node emits new message instead of received one and drops additional data #3

Closed lebaston100 closed 3 years ago

lebaston100 commented 3 years ago

After upgrading from version 0.5.8 to 0.6.0 the node no longer passes on the message that it received. This can be observed by looking at the debug out and also the message id of the node in the attached picture. This makes it impossible to work in the native node-red way of passing on messages because all the previous information is lost when passing though the node. oracle_problem

NetHans commented 3 years ago

I can confirm this. For the use of the node, it is essential that the data from the input message is transferred to the output message (except for payload). Without a corresponding adjustment, the Node in version 0.6 cannot be used sensibly.

vtulluru commented 3 years ago

@recursivecodes , Can you please take a look at this issue? Apparently, we are losing message context after querying.

recursivecodes commented 3 years ago

I'll take a look.

recursivecodes commented 3 years ago

I've pushed a fix for this. This is certainly not a regression, as the original message was never being passed along - but it is now. @vtulluru - can you publish a new version to NPM?

https://github.com/vtulluru/node-red-contrib-oracledb-mod/commit/63b8835b392be5b8ee0950192c3e05c954bfa53e

vtulluru commented 3 years ago

I will check and push it shortly. Thanks!

vtulluru commented 3 years ago

Fix has been verified and published to npm.

image