The default value for gaussian_prob

vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning

MIT License

1.39k stars 181 forks source link

The default value for gaussian_prob #297

Closed yutaro-s closed 1 year ago

yutaro-s commented 1 year ago

The default value for gaussian_prob is 0.5. https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L199 https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L272 https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L336 https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L399

But, the docstrings state 0.0. https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L221 https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L293 https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L357 https://github.com/vturrisi/solo-learn/blob/main/solo/data/pretrain_dataloader.py#L423

vturrisi commented 1 year ago

Thanks for letting us know. There's likely some other inconsistencies with our docstrings/documentations but we need to do a general pass on that and fix all of those together.