vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning
MIT License
1.39k stars 181 forks source link

Sphinx actions #299

Closed turian closed 1 year ago

turian commented 1 year ago

This adds github actions for sphinx build and sphinx link check. I also found one broken link.

This isn't perfect because it gets warnings like this:

WARNING: autodoc: failed to import class 'pretrain_dataloader.NCropAugmentation' from module 'solo.utils'; the following exception was raised:
No module named 'solo.utils.pretrain_dataloader'

I think this is because of whether the pip install actually creates the right module names.

vturrisi commented 1 year ago

Hi @turian thanks for contributing. Just so I get it, this will simply check if sphinx is building correctly?

vturrisi commented 1 year ago

I've also just checked and this error is because we changed the structure of the library but did not update the docs. I'll try to address this next week.

turian commented 1 year ago

Hi @turian thanks for contributing. Just so I get it, this will simply check if sphinx is building correctly?

Correct, and also that no links are broken. This is useful for when you start publishing docs on rtfd

vturrisi commented 1 year ago

I see @turian. Gonna check the commit later today/tomorrow and also use your PR to fix the issues that we have with the current documentation.

codecov[bot] commented 1 year ago

Codecov Report

Merging #299 (11ae827) into main (d830ce1) will not change coverage. The diff coverage is n/a.

Flag Coverage Δ *Carryforward flag
cpu 81.68% <ø> (ø)
dali 40.06% <ø> (ø) Carriedforward from 41aa1b4

*This pull request uses carry forward flags. Click here to find out more.

turian commented 1 year ago

@vturrisi Great. I'm excited to work with sololearn but without built docs its hard to know where to start.

In particular, I want to start using solo-learn for non-vision data, using different backbones, and port from my existing vicreg implementation.

vturrisi commented 1 year ago

@turian yes, indeed one thing that's not solidified is our documentation. Hopefully we will get around it in the next months.