search

vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning
MIT License
1.39k stars 181 forks source link

About knn evaluation with faiss #314

Closed Dongwoo-Im closed 1 year ago

Dongwoo-Im commented 1 year ago

Hi, thanks for your release such a nice framework.

I wonder why you did not finish the job of the branch "fix/knn-faiss"

If there's some reason, please let me know. Thanks.

DonkeyShot21 commented 1 year ago

Hi! Thank you for using solo-learn.

If I remember correctly we found that the advantages of using faiss were not worth it in the end.

vturrisi commented 1 year ago

Yeah, I think it was something like @DonkeyShot21 said. However, we would be happy to integrate knn with faiss if you choose to contribute. We can always help with that as well :)

Dongwoo-Im commented 1 year ago

Thanks for your quick response.

If there's an advantage of using faiss, I'll reopen the issue :]