vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning
MIT License
1.39k stars 181 forks source link

bump PL dependencies #315

Closed Borda closed 1 year ago

Borda commented 1 year ago

setting some more recent dependencies see tests in https://github.com/Lightning-AI/ecosystem-ci/pull/82

Borda commented 1 year ago

@vturrisi could you pls approve running your CI? :otter:

codecov[bot] commented 1 year ago

Codecov Report

Merging #315 (6c61e70) into main (d418d09) will increase coverage by 2.50%. The diff coverage is n/a.

:exclamation: Current head 6c61e70 differs from pull request most recent head e74719b. Consider uploading reports for the commit e74719b to get more accurate results

Additional details and impacted files | Flag | Coverage Δ | | *Carryforward flag | |---|---|---|---| | cpu | `81.42% <ø> (ø)` | | | | dali | `39.38% <ø> (ø)` | | Carriedforward from [6f19d5d](https://codecov.io/gh/vturrisi/solo-learn/commit/6f19d5dc38fb6521e7fdd6aed5ac4a30ef8f3bd8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) to find out more. | [Impacted Files](https://codecov.io/gh/vturrisi/solo-learn/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | Coverage Δ | | |---|---|---| | [solo/data/dali\_dataloader.py](https://codecov.io/gh/vturrisi/solo-learn/pull/315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9kYXRhL2RhbGlfZGF0YWxvYWRlci5weQ==) | `91.84% <0.00%> (+25.10%)` | :arrow_up: |
Borda commented 1 year ago

@vturrisi seem that the same failing tests are coming from the master as I see being fixed in #312

vturrisi commented 1 year ago

Yes, the builder has some issues which I still haven't had the time to solve. I'll likely disable it for the time being sometime today. Then I can commit and pull the fixes here.

vturrisi commented 1 year ago

@Borda merged this with #312.