vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning
MIT License
1.42k stars 185 forks source link

CI: precommit #316

Closed Borda closed 1 year ago

Borda commented 1 year ago

Add pre-commit which would is defined already and the auto-black does not work for fork PRs Also, I would suggest enabling this bot - https://pre-commit.ci/ which would push fixes for any/all PRs

Borda commented 1 year ago

@vturrisi mind checking this suggestion and approving CI? :otter:

vturrisi commented 1 year ago

@Borda just approved the CI. I'll check it tomorrow. Thanks!

codecov[bot] commented 1 year ago

Codecov Report

Merging #316 (6580504) into main (6f19d5d) will decrease coverage by 2.50%. The diff coverage is 100.00%.

Additional details and impacted files | Flag | Coverage Δ | | *Carryforward flag | |---|---|---|---| | cpu | `81.42% <ø> (ø)` | | | | dali | `39.38% <100.00%> (ø)` | | Carriedforward from [6f19d5d](https://codecov.io/gh/vturrisi/solo-learn/commit/6f19d5dc38fb6521e7fdd6aed5ac4a30ef8f3bd8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) to find out more. | [Impacted Files](https://codecov.io/gh/vturrisi/solo-learn/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | Coverage Δ | | |---|---|---| | [solo/data/dali\_dataloader.py](https://codecov.io/gh/vturrisi/solo-learn/pull/316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9kYXRhL2RhbGlfZGF0YWxvYWRlci5weQ==) | `66.74% <100.00%> (-25.11%)` | :arrow_down: |
vturrisi commented 1 year ago

I'm not really knowledged about pre-commit, but LGTM as it doesn't break anything.