search

vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning
MIT License
1.42k stars 185 forks source link

Support 0<data_fraction<1 for CustomDatasetWithoutLabels #328

Closed kaland313 closed 1 year ago

kaland313 commented 1 year ago

This pull request provides a fix to issue #327.

codecov[bot] commented 1 year ago

Codecov Report

Merging #328 (073c078) into main (74c1d6d) will decrease coverage by 0.08%. The diff coverage is 0.00%.

Additional details and impacted files | Flag | Coverage Δ | | *Carryforward flag | |---|---|---|---| | cpu | `81.34% <0.00%> (-0.08%)` | :arrow_down: | | | dali | `39.43% <ø> (+0.04%)` | :arrow_up: | Carriedforward from [74c1d6d](https://codecov.io/gh/vturrisi/solo-learn/commit/74c1d6d554e467d868a556b97c66eebf72316f9f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) to find out more. | [Impacted Files](https://codecov.io/gh/vturrisi/solo-learn/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | Coverage Δ | | |---|---|---| | [solo/data/pretrain\_dataloader.py](https://codecov.io/gh/vturrisi/solo-learn/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9kYXRhL3ByZXRyYWluX2RhdGFsb2FkZXIucHk=) | `70.67% <0.00%> (-2.20%)` | :arrow_down: |
vturrisi commented 1 year ago

@kaland313 thanks for spotting this. Looking at the fix, it seems fine.