search

vturrisi / solo-learn

solo-learn: a library of self-supervised methods for visual representation learning powered by Pytorch Lightning
MIT License
1.38k stars 181 forks source link

Temporary fix for DALI and bump pytorch lightning version #351

Closed vturrisi closed 1 year ago

vturrisi commented 1 year ago

Following https://github.com/Lightning-AI/lightning/issues/12956 and https://github.com/NVIDIA/DALI/pull/4881

codecov[bot] commented 1 year ago

Codecov Report

Merging #351 (27953f7) into main (51b7b07) will decrease coverage by 1.21%. The diff coverage is 11.81%.

Additional details and impacted files | Flag | Coverage Δ | | *Carryforward flag | |---|---|---|---| | cpu | `80.27% <11.81%> (-0.67%)` | :arrow_down: | | | dali | `38.94% <ø> (-0.55%)` | :arrow_down: | Carriedforward from [83a81a3](https://app.codecov.io/gh/vturrisi/solo-learn/commit/83a81a34946a4d7d2b9417bcc12ab040fbc46079?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) to find out more. | [Impacted Files](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi) | Coverage Δ | | |---|---|---| | [solo/data/dali\_dataloader.py](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9kYXRhL2RhbGlfZGF0YWxvYWRlci5weQ==) | `55.50% <0.00%> (-5.29%)` | :arrow_down: | | [solo/data/temp\_dali\_fix.py](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9kYXRhL3RlbXBfZGFsaV9maXgucHk=) | `0.00% <0.00%> (ø)` | | | [solo/utils/misc.py](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby91dGlscy9taXNjLnB5) | `59.61% <50.00%> (-0.49%)` | :arrow_down: | | [solo/data/\_\_init\_\_.py](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9kYXRhL19faW5pdF9fLnB5) | `75.00% <66.66%> (-10.72%)` | :arrow_down: | | [solo/args/pretrain.py](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9hcmdzL3ByZXRyYWluLnB5) | `88.75% <71.42%> (-1.92%)` | :arrow_down: | | [solo/methods/base.py](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi#diff-c29sby9tZXRob2RzL2Jhc2UucHk=) | `89.00% <100.00%> (+0.07%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/vturrisi/solo-learn/pull/351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Victor+Turrisi)