Ignore Case Decision on True False validation (FIXME)

vubiostat / redcapAPI

R interface to REDCap (http://www.project-redcap.org/)

21 stars 27 forks source link

Ignore Case Decision on True False validation (FIXME) #370

Closed spgarbet closed 6 months ago

spgarbet commented 6 months ago

Make a decision and implement.

https://github.com/vubiostat/redcapAPI/blob/main/tests/testthat/test-053-fieldValidationAndCasting.R#L176-L177

spgarbet commented 6 months ago

My vote is that I don't really care about case. If a user hand wrote a "TrUe" as free form text and later the field was changed to be a TRUE/FALSE, the intent is still clear.

spgarbet commented 6 months ago

@nutterb Thoughts?

nutterb commented 6 months ago

I agree with that. Case insensitive seems preferable

spgarbet commented 6 months ago

Since this is just removing a comment, I skipped the PR.