vubiostat / redcapAPI

R interface to REDCap (http://www.project-redcap.org/)
21 stars 27 forks source link

Loosen import meta data val 381 #388

Closed spgarbet closed 5 months ago

spgarbet commented 5 months ago

Fixing importMetaData validations.

spgarbet commented 5 months ago

─ R CMD check results redcapAPI 2─ Duration: 38s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

R CMD check succeeded

obregos commented 5 months ago

All the tests pass, except I am getting errors for the logging tests again.

── Failure: Logs can be batched and match unbatched ────────────────────────────
BatchedLog$action not equal to SameLog$action.
Modes: logical, character
target is logical, current is character

── Failure: Logs can be batched and match unbatched ────────────────────────────
BatchedLog$username not equal to SameLog$username.
Modes: logical, character
target is logical, current is character

── Failure: Logs can be batched and match unbatched ────────────────────────────
BatchedLog$details not equal to SameLog$details.
Modes: logical, character
target is logical, current is character

── Failure: Logs can be batched and match unbatched ────────────────────────────
BatchedLog$record not equal to SameLog$record.
Modes: logical, character
target is logical, current is character

The BatchedLog record, username, details and action are all type logical and the fields for SameLog are character.

> BatchedLog$record
logical(0)
> SameLog$record
character(0)
spgarbet commented 5 months ago

This is a false positive. There are no logs in this project at this point in the past. I will need to add some logic to skip the test in this case.

spgarbet commented 5 months ago

Fixed issue with the tests.