search

vubiostat / redcapAPI

R interface to REDCap (http://www.project-redcap.org/)
21 stars 27 forks source link

update roxygen, imports in redcapAPI-package.R #395

Closed couthcommander closed 4 months ago

couthcommander commented 4 months ago

royxgen2 isn't generating "importFrom" in NAMESPACE. These should be defined in "redcapAPI-package.R".

couthcommander commented 4 months ago

After further investigation, importFrom was in individual files. This approach is fine, though I prefer storing all in a single location. Additionally many imports were missing. This too is fine, in the sense that CHECK doesn't fail, but it's probably bad practice.

spgarbet commented 4 months ago

The thinking in roxygen was that importFrom would be closest to the usage. With the fan-in of documentation it drifts further and further away.