search

vue-a11y / vue-a11y.com

Vue.js community effort to improve web accessibility - Website.
https://vue-a11y.com/
MIT License
62 stars 7 forks source link

Add Vue announcer intro post #33

Closed marcus-herrmann closed 3 years ago

marcus-herrmann commented 3 years ago

Like mentioned in vue_a11y's Discord: Modified version of https://marcus.io/blog/accessible-notifications-vue-announcer2

ktquez commented 3 years ago

@marcus-herrmann Add you data here https://github.com/vue-a11y/vue-a11y.com/blob/master/src/.vuepress/config/authors.js

With username: 'marcus-herrmann'

ktquez commented 3 years ago

@marcus-herrmann LGTM.

Can we publish?

marcus-herrmann commented 3 years ago

Sure

marcus-herrmann commented 3 years ago

Is the blog post held back until the Vue 3 version of announcer is out (and updated)?

ktquez commented 3 years ago

Hi @marcus-herrmann, how are you?

I was updating the posting page and was going to contact you for a rebase.

I hadn't thought about that, about waiting to have the post with the most updated version. What do you think?

Acho que não tem problema de publicar esse agora, qualquer novidade vamos atualizando o post.

But you decide.

I'm in vue-axe at the moment and will go to the vue-announcer probably tomorrow. I believe in the weekend be updated to version 3 and with a new approach.

About the current post, would it be better to decrease the size of the paragraphs a little? Maybe split into smaller blocks of text.

ktquez commented 3 years ago

When you update this PR, Netlify is already generating a preview.

marcus-herrmann commented 3 years ago

What do you think?

Let's wait with the merge. I'll update the post when announcer hits 3

marcus-herrmann commented 3 years ago

Since I find the deploy preview a little bit too hidden in the GitHub interface: https://deploy-preview-33--vue-a11y.netlify.app/posts/vue-announcer/

I also added some CSS fixes. The list display was a little off, and I tried to fix the pseudo element responsible for list bullet display.

ktquez commented 3 years ago

I also found it strange that the preview was so hidden. I will see in the Netlify doc if there is a way to make it more visible.

ktquez commented 3 years ago

@marcus-herrmann Would it be possible to add the README link (doc) for v3? https://github.com/vue-a11y/vue-announcer/blob/next/README.md

ktquez commented 3 years ago

LGTM

First post of the project 🥳🥳🎉🎉

marcus-herrmann commented 3 years ago

@ktquez What an honour 😊

Updated PR.