Setting JP og:Image - Githubissues

vue-a11y / vue-a11y.com

Vue.js community effort to improve web accessibility - Website.

https://vue-a11y.com/

MIT License

62 stars 7 forks source link

Setting JP og:Image #43

Closed yamanoku closed 3 years ago

yamanoku commented 3 years ago

resolve #36

netlify[bot] commented 3 years ago

Deploy request for vue-a11y accepted.

Accepted with commit 4964ce1f6e1c9a848772a5ed7ab9555150380df8

https://app.netlify.com/sites/vue-a11y/deploys/600ce5ec3e025c0007da803a

yamanoku commented 3 years ago

👍

Twitter cards with jp URLs don't reflect the images yet. I'm sure it'll be able to see this once it's applied to master merged. @ktquez

ktquez commented 3 years ago

Vuepress managed to replace twitter:image, but theog:image it doubled.

See if modifying the og:image to

['meta', {property: 'og:image', content: 'https://vue-a11y.com/img/social-share.png'}]

We can avoid this duplicate.

yamanoku commented 3 years ago

@ktquez I found out why there was a duplication.

It was because I was trying to overwrite the meta name where it was set in the meta property. I was able to avoid this duplication with 4964ce1 (#43).

ktquez commented 3 years ago

Awesome!!! Thanks @yamanoku

yamanoku commented 3 years ago

🎉