vue-bulma / modal

Modal component for Vue Bulma
MIT License
49 stars 28 forks source link

:closable="true" ignored for background #9

Closed dasDaniel closed 6 years ago

dasDaniel commented 7 years ago

In the template(s) you have this <div class="modal-background" @click="deactive"></div>

and this <button class="modal-close" @click="deactive" v-if="closable"></button>

both actions point to

deactive () {
   this.show = false
}

so while the button may be hidden, the action of the background would still fire

please look at pull review for suggestion to fix https://github.com/vue-bulma/modal/pull/8