search

vue-bulma / nprogress

Progress bars is based on nprogress for Vue
MIT License
184 stars 31 forks source link

Fixed cancel errors #19

Closed serge1peshcoff closed 4 years ago

serge1peshcoff commented 6 years ago

When cancelling the request with axios, the nprogress bar gets stuck. I've tweaked it so it'd increase if the error is the cancellation error.

(The only change I made is in src/index.js, the others were auto-generated)

serge1peshcoff commented 6 years ago

@fundon can you look into that?

lucianobosco commented 4 years ago

Hey @serge1peshcoff , how can I make use of your fix? I'm facing this same issue 2 years later. This package seems to be completely deprecated. Do you have any repository to use or fork? Thanks!

serge1peshcoff commented 4 years ago

@lucianobosco I ended up copying the whole codebase to my project instead and changing it there :D

fundon commented 4 years ago

@serge1peshcoff Should I release new version?

lucianobosco commented 4 years ago

Hi @fundon , I'm sorry to intrude on the conversation but it would be great to have a new version to be updated via npm, otherwise, we have to pull your updates and compile the package. Please correct me if I'm wrong, but I guess this is the best and most elegant solution.

fundon commented 4 years ago

Landed in v0.2.0.

lucianobosco commented 4 years ago

Awesome! Now I can enjoy this feature again! Thank you so much, it's working as expected