search

vue-electron / vuex-electron

Integration of Vuex and Electron
MIT License
305 stars 97 forks source link

Move electron from `dependencies` to `devDependencies` #16

Closed jzj1993 closed 5 years ago

jzj1993 commented 5 years ago

I'm using electron-vue to build my application. And I encountered a problem that the .app and DMG file is too large after build with electron-builder.

The problem has been described here https://github.com/electron-userland/electron-builder/issues/3573

Finally I found the reason is that vuex-electron declares a dependency of electron. So I think it may be better if move electron from dependencies to devDependencies.

davestewart commented 5 years ago

Perhaps it should be a peer dependency?

akodkod commented 5 years ago

@jzj1993 @davestewart thank you for the suggestions, functionality will be released soon.

Commit: https://github.com/vue-electron/vuex-electron/commit/e8c77a33b2c8c5a91570192723067254c5cc14ef