search

vue-final / vue-final-modal

🍕Vue Final Modal is a tiny, renderless, mobile-friendly, feature-rich modal component for Vue.js.
https://vue-final-modal.org
MIT License
864 stars 95 forks source link

Implement support for setting the aria-labelledby attribute #372

Closed arknu closed 1 year ago

arknu commented 1 year ago

Resolves #208

This PR implements support for setting the aria-labelledby attribute, as required by accesibility standards. I have tried to follow existing conventions in the code as closely as possible.

hunterliu1003 commented 1 year ago

@arknu This PR is unnecessary. aria-labelledby is a data attribute, you can just bind it on the root of VueFinalModal:

<template>
  <VueFinalModal
    v-model="options.modelValue"
    aria-labelledby="id"
  >
    ...
  <VueFinalModal>
</template>
arknu commented 1 year ago

@hunterliu1003 Indeed, it appears that this will just work without any code changes. All for the better then, closing this PR.