search

vue-final / vue-final-modal

🍕Vue Final Modal is a tiny, renderless, mobile-friendly, feature-rich modal component for Vue.js.
https://vue-final-modal.org
MIT License
864 stars 95 forks source link

Pass real props instead of ComponentPublicInstance['$props'] #374

Closed Dodje closed 7 months ago

Dodje commented 1 year ago

Is your feature request related to a problem? Please describe.

Increasing type safety. For now my IDE says that the type of export type ComponentProps = ComponentPublicInstance['$props']; is just empty object {}

Describe the solution you'd like

Just export real props interface https://github.com/vuejs/core/pull/8083

Additional context

Due to new features of vue3.3 we now able to reuse component interfaces for more convenient usage of wrapperings components

hunterliu1003 commented 7 months ago

The props has type safety in vue-final-modal 4