vue-final / vue-final-modal

🍕Vue Final Modal is a tiny, renderless, mobile-friendly, feature-rich modal component for Vue.js.
https://vue-final-modal.org
MIT License
864 stars 95 forks source link

Parent modal can be closed using ESC key after a nested modal is opened #375

Closed Me-Phew closed 1 year ago

Me-Phew commented 1 year ago

Version

vue-final-modal: 4.4.2 vue: 3.2.47 nuxt: 3.3.2

OS

Windows

Reproduction Link

The problem can be seen in this example from the docs

Steps to reproduce

Hit escape quickly during the opening of a nested modal or soon after it opens

What is Expected?

The nested modal should stop opening or close and the parent modal should remain open

What is actually happening?

The parent modal is closing leaving the nested modal open by itself

hunterliu1003 commented 1 year ago

@Me-Phew Nice catch!

hunterliu1003 commented 1 year ago

@Me-Phew It was fixed in v4.4.3

Me-Phew commented 1 year ago

@hunterliu1003 Great, thanks!