vue-final / vue-final-modal

🍕Vue Final Modal is a tiny, renderless, mobile-friendly, feature-rich modal component for Vue.js.
https://vue-final-modal.org
MIT License
930 stars 99 forks source link

Typescript error for close action inside slot #432

Open liyasthomas opened 9 months ago

liyasthomas commented 9 months ago

Version

vue-final-modal: v4.5.4 vue: v3.4.19

OS

Mac

Reproduction Link

Screenshot 2024-02-21 at 9 06 52 PM

Steps to reproduce

Inspired by #430 I tried to implement close action in the default slot but ended up getting the below typescript error:

Property 'close' does not exist on type '((props: { close: () => void; }) => void) | undefined'.ts

The close actions work fine, it's just the typescript issue persisting on usage.

What is Expected?

Close slot action should be typesafe.

What is actually happening?

Typescript compiler throwing error on usage.

Adizbek commented 6 days ago

This problem still exists