search

vue-final / vue-final-modal

🍕Vue Final Modal is a tiny, renderless, mobile-friendly, feature-rich modal component for Vue.js.
https://vue-final-modal.org
MIT License
931 stars 99 forks source link

fix: augment `vue` rather than `@vue/runtime-core` #451

Closed danielroe closed 2 months ago

danielroe commented 3 months ago

In line with https://github.com/vuejs/router/pull/2295 and https://github.com/nuxt/nuxt/pull/28542, this moves to augment vue rather than @vue/runtime core.

This is now officially recommended in the docs and it must be done by all libraries or it will break types for other libraries.

xollaborator commented 2 months ago

@hunterliu1003 Is there a chance to relase a patch with this change only? As I have checked in my repo, it is responsible for hundreds of errors in vue-tsc, because it is breaking types for $router (vue-router) and $t (i18n). I believe many more people will benefit and probably many did not figure out yet what dependency is breaking vue types in their case.

I hope that makes it easier to understand the impact of merging PR from Daniel. Thank you.

hunterliu1003 commented 2 months ago

@hunterliu1003 Is there a chance to relase a patch with this change only? As I have checked in my repo, it is responsible for hundreds of errors in vue-tsc, because it is breaking types for $router (vue-router) and $t (i18n). I believe many more people will benefit and probably many did not figure out yet what dependency is breaking vue types in their case.

I hope that makes it easier to understand the impact of merging PR from Daniel. Thank you.

Thanks for the reminder. I will release a patch version as soon as possible. I had a new baby last month and life got very busy.

xollaborator commented 2 months ago

@hunterliu1003 congratulations! thank you for so fast reply and all the best for your family :)

hunterliu1003 commented 2 months ago

@xollaborator Thanks ❤️ Released in v4.5.5