v3 - form destroy - error: Cannot read property 'querySelector' of undefined - Githubissues

vue-generators / vue-form-generator

:clipboard: A schema-based form generator component for Vue.js

MIT License

2.99k stars 531 forks source link

v3 - form destroy - error: Cannot read property 'querySelector' of undefined #537

Open gapipro opened 5 years ago

gapipro commented 5 years ago

I'm submitting a ...
- [x] bug report
Do you want to request a feature or report a bug? Bug
What is the current behavior? When validation is enabled and if we redirect user after successful validation to new page an error occurs in https://github.com/vue-generators/vue-form-generator/blob/v3/src/formGroup.vue#L164 this.$refs.group.querySelector saying TypeError: Cannot read property 'querySelector' of undefined.

Most probably this happens because $ref is destroyed before $nextTick callback is triggered.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. I would prepare fiddle but I haven't managed to get v3 working there.
What is the expected behavior? To destroy form normally without any errors
Please tell us about your environment:
- Version: [3.0.0-beta.7]
- Browser: [all ]
- Language: [all]

zoul0813 commented 5 years ago

Hrm, the nextTick isn’t necessary here as it’s being pushed through the event bus which is already going to fire on the next tick... no?