Warn if project path contains characters that cause problems with HMR

vuejs-templates / webpack

A full-featured Webpack + vue-loader setup with hot reload, linting, testing & css extraction.

MIT License

9.7k stars 4.38k forks source link

Warn if project path contains characters that cause problems with HMR #679

Open nothingrandom opened 7 years ago

nothingrandom commented 7 years ago

Not so much an issue, just a nice to have future feature change - potentially not possible, depends on how hot reloading currently happens.

Summary of the issue;

If your directory, ex. "My App" has a space hot reload doesn't work. You instead have to call it "my_app", "my-app" etc etc.

A nice MVP fix for this would be that when you run npm run dev, you get a console warning that hot reload won't work whilst there is a space in the dir name.

shailendher commented 7 years ago

Hi,

I tried this on a newly created project and hot reload seems to work. Or did I do something wrong?

`D:\temp\my app>npm run dev

my_app@1.0.0 dev D:\temp\my app node build/dev-server.js

Starting dev server...

DONE Compiled successfully in 5889ms

Listening at http://localhost:8080

WAIT Compiling...

DONE Compiled successfully in 343ms`

LinusBorg commented 7 years ago

@nothingrandom Not a bad idea at all. HMR doesn't like brackets / parethesis as well. Would be a nice hint to give users.