vuejs / component-compiler-utils

Lower level utilities for compiling Vue single file components
319 stars 75 forks source link

Reason for pinning prettier to specific version, 1.16.3? #55

Closed frankandrobot closed 5 years ago

frankandrobot commented 5 years ago

In our build we have noticed an inconsistency with dependencies. Namely, we noticed that yarn is pulling in two versions of prettier. Upon investigation, it was because this package asks for a specific version of prettier (while our app asks for another). Other Vue packages (for example, @vue/eslint-config-prettier) require minor versions---^1.16.3

Is this possibly a bug? Should it be ^1.16.3 as well? Or is there a reason for this specific version of prettier?

yyx990803 commented 5 years ago

Prettier has shipped breaking changes in minor releases before, that's why we are pinning the version.

chris-humu commented 5 years ago

@yyx990803 I have a different package in my project that also requires a different and specific Prettier version, and the two can't be reconciled. Can we make it a peer dependency?