search

vuejs / component-compiler-utils

Lower level utilities for compiling Vue single file components
319 stars 75 forks source link

fix: add parse options to cache key #78

Closed meteorlxy closed 4 years ago

meteorlxy commented 4 years ago

Currently, if we call parse() on a same file with different compilerParseOptions, it will return the same cached result, which is supposed to be differed:

const a = parse({
  source: 'aaa',
  filename: 'bbb',
  compilerParseOptions: { pad: 'line' },
})

// `b` is unexpectly cached, which leads to a wrong result
const b = parse({
  source: 'aaa',
  filename: 'bbb',
  compilerParseOptions: { pad: 'space' },
})
meteorlxy commented 4 years ago

BTW, does vuejs accept more core members?

Currently I'm one of the collaborators of VuePress. It has been more than three months since VuePress' last release, but the whole collaborator team does not have access to publish VuePress npm package.

I'm willing to help maintain VuePress if our current team leader ulivz is busy now.

yyx990803 commented 4 years ago

@meteorlxy that would be great. ^ @ulivz what do you think?