search

vuejs / component-compiler-utils

Lower level utilities for compiling Vue single file components
321 stars 75 forks source link

Provide installation instructions on missing language preprocessors #8

Closed znck closed 6 years ago

znck commented 6 years ago

If a template is using pug syntax and pug package is not installed, it fails. There should be graceful warning explaining what failed and how to resolve it.

For example:

Component Example.vue uses lang pug for template. Please install the language preprocessor.

$ npm add -D pug

mikemenaker commented 6 years ago

@znck I'm working on this issue and think I have a solution, I tried to create a branch (to make sure I'm on the right track) but don't have access.

Should I fork it then create a branch off of that or what's the protocol?

Thanks.

znck commented 6 years ago

Yes. Fork it. Create a branch and send PR as early as possible. Add [WIP] to the PR title until it is ready to be merged.

mikemenaker commented 6 years ago

PR: https://github.com/vuejs/component-compiler-utils/pull/10

mikemenaker commented 6 years ago

@znck not sure if you get notifications on PR updates, but I pushed a commit yesterday to address your feedback.

LinusBorg commented 6 years ago

This got merged so I assume the issue can be closed.