search

vuejs / component-compiler-utils

Lower level utilities for compiling Vue single file components
319 stars 75 forks source link

feat: upgrade prettier #87

Closed FauxFaux closed 4 years ago

FauxFaux commented 4 years ago

Literally just bump prettier.

Unfortunately, this brings with it some new defaults, and a load of irrelevant changes. If you want, you can disable trailingComma in .prettierrc, instead?

This is useful to me because it reduces the number of copies of prettier I have to install, as optional in npm doesn't actually mean optional.

sodatea commented 4 years ago

See https://github.com/vuejs/component-compiler-utils/issues/84#issuecomment-610766279

Bumping prettier version would mean breaking changes for a whole lot of Vue core packages, including vue-loader and @vue/cli. And as you can see, vue-loader v16 is aimed for Vue 3 support, so we are not going to ship yet another major version for such niche use cases.

In the foreseeable future, I think the only viable solution is to make prettier an optional peer dependency. It would still mean breaking change in this package, though. So might better ship it along with some other planned breaking changes so as not to waste a major version number.