vuejs / core-vapor

Vue Vapor is a variant of Vue that offers rendering without the Virtual DOM.
https://vapor-repl.netlify.app
MIT License
1.8k stars 86 forks source link

ci: continuous releases with pkg.pr.new #264

Closed Aslemammad closed 1 month ago

Aslemammad commented 1 month ago

I didn't remove the release file completely, for now let's just see if this works by just adding pkg.pr.new!

Before running the workflows for this PR, the github app should be installed!

Thank you so much @sxzz for the opportunity!

netlify[bot] commented 1 month ago

Deploy Preview for vapor-template-explorer ready!

Name Link
Latest commit fc3c721c7c40055ba447c3569e42a69252b001e0
Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/66a41eea4906a0000807c4c6
Deploy Preview https://deploy-preview-264--vapor-template-explorer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for vapor-repl ready!

Name Link
Latest commit fc3c721c7c40055ba447c3569e42a69252b001e0
Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66a41eea49e18b000865a987
Deploy Preview https://deploy-preview-264--vapor-repl.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.5 kB 28.3 kB 25 kB
compiler-vapor.global.prod.js 56.9 kB 19.4 kB 17.6 kB
runtime-dom.global.prod.js 94.6 kB 35.9 kB 32.4 kB
runtime-vapor.global.prod.js 48 kB 18.1 kB 16.6 kB
vue-vapor.global.prod.js 102 kB 36 kB 32.4 kB
vue.global.prod.js 152 kB 55.8 kB 49.6 kB

Usages

Name Size Gzip Brotli
createApp 54.3 kB 20.9 kB 19.1 kB
createSSRApp 57.9 kB 22.4 kB 20.4 kB
defineCustomElement 56.6 kB 21.7 kB 19.8 kB
vapor 48.6 kB 18.3 kB 16.7 kB
overall 67.9 kB 26 kB 23.6 kB
sxzz commented 1 month ago

Release job is skipped

sxzz commented 1 month ago

CI failed 🤔

Aslemammad commented 1 month ago

yea I missed the command! Now let's see if it works.

pkg-pr-new[bot] commented 1 month ago

commit: fc3c721

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-core@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-dom@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-sfc@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-ssr@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-vapor@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/reactivity@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-core@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-dom@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-shared@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-vapor@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/server-renderer@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/shared@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/vue@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compat@264
pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/vapor@264

Open in Stackblitzplayground

sxzz commented 1 month ago

Great! Thanks for your contribution and pkg.pr.new!

By the way, if we can select specific packages to display in the comments, it will look better. https://github.com/vuejs/core-vapor/pull/264#issuecomment-2253232476

Aslemammad commented 1 month ago

Thank you so much for the opportunity, Kevin!

Yep, I agree, I'm looking to find ways on how to decrease the space each comment uses, I'll do my best to come up with something good.

sxzz commented 1 month ago

https://github.com/vue-macros/vue-macros/pull/746#issuecomment-2253790813

I also added pkg.pr.new to Vue Macros, the comment content is really too long. Maybe we can use <details> to fold it.

Aslemammad commented 1 month ago

Thank you so much, Sure, I just fixed this issue, will keep you updated on new release!

What do you think about this format? https://github.com/stackblitz-labs/pkg.pr.new/pull/156#issuecomment-2247757002

sxzz commented 1 month ago

Looks good, thank you!