search

vuejs / core

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
https://vuejs.org/
MIT License
45.6k stars 8k forks source link

refactor(compiler-core): code refactor #11198

Closed Simon-He95 closed 1 week ago

yyx990803 commented 1 week ago

Thanks for the PR, but please see https://github.com/vuejs/core/blob/main/.github/contributing.md#what-kinds-of-pull-requests-are-accepted

This PR also contains a few places where it alters the logic of the original code, and may lead to subtle issues.

Simon-He95 commented 1 week ago

Thanks for the PR, but please see https://github.com/vuejs/core/blob/main/.github/contributing.md#what-kinds-of-pull-requests-are-accepted感谢您的公关，但请参阅 https://github.com/vuejs/core/blob/main/.github/contributing.md#what-kinds-of-pull-requests-are-accepted

This PR also contains a few places where it alters the logic of the original code, and may lead to subtle issues.此 PR 还包含一些更改原始代码逻辑的地方，并可能导致微妙的问题。

image

thank you for your reply， Since the compiler logic should be relatively stable, I think this modification is desirable. It will reduce an extra conditional judgment and bring some performance benefits.