search

vuejs / core

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
https://vuejs.org/
MIT License
45.6k stars 8k forks source link

ci: fix size-report #11203

Closed ferferga closed 1 week ago

ferferga commented 1 week ago
ferferga commented 1 week ago

Hello @sxzz

For some reason, it looks like GitHub is completely skipping the pr_number input. I'm not sure why, but I believe it's due to the formatting of the tag, maybe it not being enclosed in quotes is tripping the actions interpreter.

There was also a recent update to the action that I missed that already adds the comment tag as a hidden marker, no need to enclose it in comment markers ourselves. With current workflow, a quote marker would appear below the report.

Sorry for all the hassle. I opened https://github.com/vuejs/core/pull/11204 to fix these mistakes. I have a sample run in my fork in case you want to check it as well.