vuejs / core

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
https://vuejs.org/
MIT License
47.75k stars 8.35k forks source link

workflow: fix the vitest bench ran twice #12313

Closed LittleSound closed 1 week ago

LittleSound commented 2 weeks ago

Our repo has two vitest config files, vitest.e2e.config.ts and vitest.unit.config.ts. these two config are responsible for different parts.

However. the same Benchmark was mistakenly run twice because the exclude and include for the benchmark needs to be configured separately.

image

github-actions[bot] commented 2 weeks ago

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB
pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

@vue/compiler-core

``` pnpm add https://pkg.pr.new/@vue/compiler-core@12313 ```

@vue/compiler-dom

``` pnpm add https://pkg.pr.new/@vue/compiler-dom@12313 ```

@vue/compiler-ssr

``` pnpm add https://pkg.pr.new/@vue/compiler-ssr@12313 ```

@vue/compiler-sfc

``` pnpm add https://pkg.pr.new/@vue/compiler-sfc@12313 ```

@vue/reactivity

``` pnpm add https://pkg.pr.new/@vue/reactivity@12313 ```

@vue/runtime-core

``` pnpm add https://pkg.pr.new/@vue/runtime-core@12313 ```

@vue/runtime-dom

``` pnpm add https://pkg.pr.new/@vue/runtime-dom@12313 ```

@vue/server-renderer

``` pnpm add https://pkg.pr.new/@vue/server-renderer@12313 ```

@vue/shared

``` pnpm add https://pkg.pr.new/@vue/shared@12313 ```

vue

``` pnpm add https://pkg.pr.new/vue@12313 ```

@vue/compat

``` pnpm add https://pkg.pr.new/@vue/compat@12313 ```

commit: 6e83b65

edison1105 commented 1 week ago

This PR is no longer needed due to https://github.com/vuejs/core/commit/83430a35f4865f02e6ab1029add66bf36dd26c5c

LittleSound commented 1 week ago

Fixed in https://github.com/vuejs/core/commit/83430a35f4865f02e6ab1029add66bf36dd26c5c