vuejs / core

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
https://vuejs.org/
MIT License
47.75k stars 8.35k forks source link

fix(compiler-core): comment node should be cached when user-enabled comment retention #12419

Closed linzhe141 closed 4 days ago

linzhe141 commented 5 days ago

close #12417

github-actions[bot] commented 5 days ago

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB (+152 B) 57.8 kB (+39 B) 51.5 kB (+70 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.3 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.3 kB 23.1 kB 21 kB
defineCustomElement 60.1 kB 22.9 kB 20.8 kB
overall 69.1 kB 26.5 kB 24.1 kB
pkg-pr-new[bot] commented 5 days ago

Open in Stackblitz

@vue/compiler-core

``` pnpm add https://pkg.pr.new/@vue/compiler-core@12419 ```

@vue/compiler-sfc

``` pnpm add https://pkg.pr.new/@vue/compiler-sfc@12419 ```

@vue/compiler-dom

``` pnpm add https://pkg.pr.new/@vue/compiler-dom@12419 ```

@vue/compiler-ssr

``` pnpm add https://pkg.pr.new/@vue/compiler-ssr@12419 ```

@vue/runtime-core

``` pnpm add https://pkg.pr.new/@vue/runtime-core@12419 ```

@vue/runtime-dom

``` pnpm add https://pkg.pr.new/@vue/runtime-dom@12419 ```

@vue/reactivity

``` pnpm add https://pkg.pr.new/@vue/reactivity@12419 ```

@vue/server-renderer

``` pnpm add https://pkg.pr.new/@vue/server-renderer@12419 ```

@vue/shared

``` pnpm add https://pkg.pr.new/@vue/shared@12419 ```

vue

``` pnpm add https://pkg.pr.new/vue@12419 ```

@vue/compat

``` pnpm add https://pkg.pr.new/@vue/compat@12419 ```

commit: 6c71d08

edison1105 commented 4 days ago

This changes the same as https://github.com/vuejs/core/pull/10748/files