vuejs / devtools-v6

⚙️ Browser devtools extension for debugging Vue.js applications.
https://devtools-v6.vuejs.org/
MIT License
24.69k stars 4.14k forks source link

After 2 minutes, it unloads itself #1974

Closed thany closed 1 year ago

thany commented 2 years ago

Vue devtools version

6.4.5

Link to minimal reproduction

N/A

Steps to reproduce & screenshots

Sorry, no reproduction. I don't know what causes the problem, so I have no way of knowing how to make a reproduction.

  1. Go to a Vue2 website in Firefox
  2. Open the devtools
  3. Wait a few minutes
  4. Maybe you have to do some random stuff in the devtools

What is expected?

Nothing happens. Devtools stays open, and stays functional.

What is actually happening?

One of two things may happen:

  1. The devtools unloads itself, showing just its logo.
  2. The devtools reloads itself, undoing any changes and closing the tree.

In either case, should I have been debugging, making changes, etc, I can just go and start all over. Any work that I'm doing in the devtools is rudely interrupted and goes poof, i.e. it doesn't remember any changes and doesn't recover them.

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 10.41 GB / 31.76 GB
  Binaries:
    Node: 16.18.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 106.0.5249.119
    Edge: Spartan (44.19041.1266.0), Chromium (106.0.1370.52)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vue: ^2.6.14 => 2.6.14

I don't know why so many people use this script, it's poop. Firefox is not in there.

Any additional comments?

Worked fine in some older version. Don't know which one, since browser addons update fully automatically.

dmke commented 1 year ago

2000 will fix this issue.

djpowers commented 1 year ago

Thanks @dmke for investigating and coming up with a fix!

I've been experiencing this issue for a while now so I'm looking forward to it being resolved. Is there anything else that needs to be done to have this merged and released?

dmke commented 1 year ago

Is there anything else that needs to be done to have this merged and released?

It'd be nice if someone would test #2000 against a Chromium-based browser, just to see that it doesn't break anything: https://devtools.vuejs.org/guide/contributing.html#testing-as-chrome-addon

dmke commented 1 year ago

I've found a VM where I dared to install Chrome into. As far as I can tell, the extension does not break, but displays a warning regarding Manifest v2 being deprecated (as expected).


For the impatient and trusting, I've build a .xip including this fix:

To install locally, go to about:addons and install that file like so:

image

Don't forget to disable the actual Vue.js devtools extension.

:warning: :rotating_light:

Also, it would probably a really good idea to enable notifications for either #2000 or the releases, so you don't forget to reactivate and update the actual extension (I won't keep my .xpi updated; you have been warned):

image

thany commented 1 year ago

Is this addon released yet?

If not, it's a good idea to release it to Mozilla only until Chrome is tested properly. Seeing how tremedously annoying this problem is, and all... I mean let's be honest, we've had to cope with this for months.

thany commented 1 year ago

@Akryum Just curious: is that fix a temporary workaround, or a proper permanent fix? Seeing how small of a change it is...

Akryum commented 1 year ago

It's a proper fix until the extension is fully migrated to Manifest V3 (which doesn't support background pages).

thany commented 1 year ago

So why is it closed then? It's not fixed yet, clearly.

djpowers commented 1 year ago

Thanks for releasing a new version with this fix @Akryum. I see that the new 6.5.0 update is available on the Chrome Web Store, but Firefox Browser Add-ons is still showing the 6.4.5 release from October 2022. Is there a review process at Mozilla we're waiting on, or does the updated extension still need to be submitted there?

Akryum commented 1 year ago

It's still pending review on AMO

djpowers commented 1 year ago

For anyone following this issue waiting for the new release, version 6.5.0 containing this fix is now live on AMO: https://addons.mozilla.org/en-US/firefox/addon/vue-js-devtools/versions/

Thanks again to those who helped getting this resolved! 🎉