search

vuejs / devtools

⚙️ Browser devtools extension for debugging Vue.js applications.
https://devtools.vuejs.org/
MIT License
1.7k stars 122 forks source link

fix(vite): fix inspector short key failure #558

Open wzc520pyfm opened 3 months ago

wzc520pyfm commented 3 months ago

hi~, I am working on #547 , but I found vite-plugin-vue-inspector's toggleComboKey was set to '', this makes the default shortcut key for opening the inspector invalid. When I removed it, vite-plugin-vue-inspector's toggleComboKey is working!

After this pr, I plan to add this default shortcut key for inspector to the documentation, as well as how to customize the option of vite-plugin-vue-inspector.

netlify[bot] commented 3 months ago

Deploy Preview for vue-devtools-docs canceled.

Name Link
Latest commit 5d2d73002087eb108c0e2971987d17a29bdd8f25
Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66ade002591aec000834fa60
alexzhang1030 commented 3 months ago

Probably users can configure the combo key by passing some options like the docs say.

wzc520pyfm commented 3 months ago

Probably users can configure the combo key by passing some options like the docs say.

I agree, users can customize shortcuts by passing a config, but perhaps we should provide default shortcuts as well?

alexzhang1030 commented 3 months ago

How about implementing the user-defined toggle combo key in this PR?

wzc520pyfm commented 3 months ago

How about implementing the user-defined toggle combo key in this PR?

I wrote the custom shortcut documentation in #559. The user can do this by passing Options.componentInspector.toggleComboKey to vuedevtoolnext.