search

vuejs / devtools

⚙️ Browser devtools extension for debugging Vue.js applications.
https://devtools.vuejs.org/
MIT License
1.7k stars 122 forks source link

feat(client & devtools-kit): add route-meta for pages #560

Closed wzc520pyfm closed 2 months ago

wzc520pyfm commented 3 months ago

hi~! I see #330 , this pr add route meta for pages.

Preview:

https://github.com/user-attachments/assets/c39e3dd7-77b7-4303-8fbf-eee80f29fbde

netlify[bot] commented 3 months ago

Deploy Preview for vue-devtools-docs canceled.

Name Link
Latest commit 966cc05c23b6210dc72718da5b5a3b8b076aa2ea
Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66d7396717bc7c0008c5bd5a
alexzhang1030 commented 3 months ago

the bundle size of json-editor-vue is above 500kb, this is huge... Since this is not a feature for high-frequency use, and most of the time is read instead of edited, how about just using Shiki for render meta info? We have a CodeBlock component on the @vue/devtools-ui package.

wzc520pyfm commented 2 months ago

the bundle size of json-editor-vue is above 500kb, this is huge... Since this is not a feature for high-frequency use, and most of the time is read instead of edited, how about just using Shiki for render meta info? We have a CodeBlock component on the @vue/devtools-ui package.

Sorry for delay. I have replaced json-editor-vue with CodeBlock.

webfansplz commented 2 months ago

Because the route meta info does not exist in every project, I think it is better UX to hide this field if all the routes of the user project do not have this field.