vuejs / devtools

⚙️ Browser devtools extension for debugging Vue.js applications.
https://devtools.vuejs.org/
MIT License
1.71k stars 121 forks source link

Could not open [idx].vue in the editor. #587

Closed gewisser closed 2 months ago

gewisser commented 2 months ago

Hi all

It is unclear why the issue was closed: #534

The problem exists and has not gone away: https://github.com/yyx990803/launch-editor/blob/master/packages/launch-editor/index.js#L110

image

Trying to open file:

C:\ProgramUser\ApacheDir\Ancor\frontend-app\src\pages\p2p\deals\[idx].vue

Square brackets are not allowed in regular expression

image

"vite-plugin-vue-devtools": "^7.3.9"
"launch-editor-middleware": "^2.8.1",
gewisser commented 2 months ago

I think this regular expression check is completely unnecessary. It doesn't protect against anything.

https://github.com/vuejs/devtools-next/issues/531#issuecomment-2249212867 👆 I think it will be needed more than once... ))

alexzhang1030 commented 2 months ago

That's interesting, can you file an issue on https://github.com/yyx990803/launch-editor this repo?

gewisser commented 2 months ago

That's interesting, can you file an issue on https://github.com/yyx990803/launch-editor this repo?

Pull requests have been open for almost two weeks now.: https://github.com/yyx990803/launch-editor/pull/75

gewisser commented 2 months ago

@alexzhang1030 fixed in v2.8.2

https://github.com/yyx990803/launch-editor/compare/v2.8.1...v2.8.2

alexzhang1030 commented 2 months ago

Great, you can use it once Vite has been released by this https://github.com/vitejs/vite/pull/18039.

webfansplz commented 2 months ago

This issue will be fixed in the next Vite release version, so let's close it.

gewisser commented 2 months ago

My prayers were answered))

https://github.com/yyx990803/launch-editor/compare/v2.8.2...v2.9.1#diff-f3a5176348208fec4b413a18bea297e65643a3fffb7d64e0a6806f2d9d2cb764L110

gewisser commented 2 months ago

This issue will be fixed in the next Vite release version, so let's close it.

After that, several releases came out. Now I updated everything to the latest versions, but no one updated the dependencies ((

image

image

https://github.com/vitejs/vite/blob/v5.4.5/packages/vite/package.json#L125