search

vuejs / docs

📄 Documentation for Vue 3
https://vuejs.org
Other
2.82k stars 4.14k forks source link

i18n, 404 section #2560

Open skiff26 opened 7 months ago

skiff26 commented 7 months ago

Description

When you try to go from a page on vuejs.org to ua.vuejs.org and pt.vuejs.org, like this one - https://vuejs.org/guide/essentials/application.html, you'll run into an error. I only noticed this in the docs section. It only works if you didn't change pages before trying to switch to the UA/PT version.

image image

The same problem has it.vuejs.org, an error section appears.

image

brc-dd commented 7 months ago

I think those don't have an updated vitepress version or maybe some configuration issue at their netlify/vercel. It seems to be working fine for french, chinese, japanese, korean, bangla. Only ua, pt, it have issues IG.

brc-dd commented 6 months ago

seems to be a bug in theme - https://github.com/vuejs/theme/blob/main/src/vitepress/components/VPNavBarLocaleItems.vue#L18 (normalization should be done here and probably should use page.relativePath instead)

skiff26 commented 6 months ago

So, do I need to recreate this issue in the vuejs/theme?

brc-dd commented 6 months ago

No need. I'll update both.

skirtles-code commented 4 months ago

I think #2664 is related.

brc-dd commented 4 months ago

Yeah, sorry. I actually forgot about this. I'll fix the theme. I don't think any of the translations sites are using cleanUrls, so that vercel fix should work fine too 👀

Jinjiang commented 4 months ago

Same issue as https://github.com/vuejs-translations/docs-pt/issues/128